TODO: re-enable PublishTrimmed once JSON serialisation is trim-safe#19
Merged
Conversation
PublishTrimmed is disabled in the App csproj to unblock the first release (see PR #18). Document the proper fix so it doesn't get lost: source-gen JsonSerializerContext to remove IL2026, audit the third-party IL2104 warnings, then turn PublishTrimmed back on. Payoff is a meaningfully smaller self-contained Velopack package. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Two loose threads from the v0.1.0-alpha.1 release session worth capturing before they're lost: - Code-sign the installer. The unsigned alpha trips SmartScreen's "not commonly downloaded" warning. Documents the three options (Azure Trusted Signing recommended, OV cert, EV cert), the recipe for the Azure Trusted Signing path, and the open cost / Velopack- signing questions. - Tighten the iteration loop. The build/run/debug cycle used PRs as the feedback loop because the App project can't be fully built on Linux. Three independent improvements: EnableWindowsTargeting for local builds (catches analyser rules before push), branch protection for required status checks (prevents the merged-red failure mode), and the draft-PR-plus-force-push-fixup convention for keeping merged history clean. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
… CLI) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…target Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Drop the five carried-over items that have since shipped: backup retention, CLI delete, Trash UI, Nerdbank.GitVersioning, and Markdown rendering. The remaining carried-over items (hotkey rebinding, storage-path move/adopt/warn, re-enable PublishTrimmed) and every other section are untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublishTrimmedcan be turned back on after PR Disable PublishTrimmed for Release so the release pipeline can publish #18 disables it.🤖 Generated with Claude Code